Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XDS client #115

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Add XDS client #115

merged 3 commits into from
Oct 28, 2020

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented Oct 26, 2020

Adds a grpc client that can talk to an ADS server
and forwards requests/responses from/to a cluster manager.

Adds a grpc client that can talk to an ADS server
and forwards requests/responses from/to a cluster manager.
@iffyio iffyio requested a review from markmandel October 26, 2020 18:29
@google-cla google-cla bot added the cla: yes label Oct 26, 2020
@markmandel
Copy link
Member

Just so I remember how xDS works -- the Quilkin Proxy will reach out to an xDS server through this client to get updates on the configuration state. Have I remembered that correctly?

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just me asking questions 😄

src/xds/ads_client.rs Show resolved Hide resolved
/// sending summarized cluster updates on the provided channel.
pub async fn run(
self,
log: Logger,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've been bad about enforcing this, but I like to have a source attribute for loggers, which you can see here:

Some(id) => base.new(o!("source" => "extensions::Debug", "id" => id)),

So it is obvious in the logs where are coming from. Might even want to include the node_id?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

@markmandel markmandel merged commit c8f653d into master Oct 28, 2020
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/feature New feature or request labels Oct 28, 2020
@iffyio iffyio deleted the iu/xds-ads-client branch May 16, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc cla: yes kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants